Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7828: Adding Issue Category Separately to VPN Contact Form #7829

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 3, 2023

Summary of Changes

Adding issue selector as mandatory for support, check the ticket for implementation details.

This pull request fixes #7828

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Go Settings
  2. Press Brave Firewall + VPN
  3. Press Contact Technical Support
  4. Choose (toggle) categories which are necessary
  5. Click Continue to Email
  6. Issue Selection screen presented
  7. Select a issue
  8. User email should be presented with necessary Issue in subject and body for the email

Screenshots:

supportmeialtest13211

RPReplay_Final1691096266.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner August 3, 2023 21:50
@soner-yuksel soner-yuksel self-assigned this Aug 3, 2023
@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 8, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/vpn-support-topic branch from 257837d to 2f0d075 Compare August 8, 2023 17:27
@soner-yuksel soner-yuksel enabled auto-merge (squash) August 8, 2023 17:27
@soner-yuksel soner-yuksel merged commit 8a6d5f8 into development Aug 8, 2023
@soner-yuksel soner-yuksel deleted the enhancement/vpn-support-topic branch August 8, 2023 17:57
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Issue Category Separately to VPN Contact Form
2 participants